connector: update DM user or group info on chat view#186
Open
connector: update DM user or group info on chat view#186
Conversation
Member
|
Not sure if this will actually work since GetUserInfo intentionally doesn't refetch info if the ghost already has a name. Need to investigate what kind of requests would be safe to spam |
Member
Author
Ah, knew this seemed too easy. As it stands it would fix the cases where the initial call fails for network issues I think (well, fix it on view)? So maybe worthwhile as-is.. |
Member
|
Yeah might help if that happens, although I think bridgev2 should already retry on every incoming message if the sender has no name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same idea as signal/whatsapp basically.