join group by invite link command #502
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I miss this feature, will it be rebased? There is a issue #617 |
Contributor
Author
|
Maybe. I haven't had a look at the code in almost 2 years so I don't know if it makes sense or whether a re-write is easier. I don't have time currently, but I might have time soon. No promises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #501 to create the room when the join request is accepted. There'll be an incompatibility though, this one needs to be rebased after merging #501.
I was also thinking that it might be nice to generate a matrix.to link via which the room can be joined (using knocking when admin approval is required), but this works for now, so just let me know what you think and I might implement it later.