Fix historical thread message order during backfill#63
Open
redgoat650 wants to merge 1 commit intomautrix:mainfrom
Open
Fix historical thread message order during backfill#63redgoat650 wants to merge 1 commit intomautrix:mainfrom
redgoat650 wants to merge 1 commit intomautrix:mainfrom
Conversation
Member
|
Weird, I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix thread order when backfilling history.
Currently when backfilling, the bridge seems to post thread messages in reverse chronological order.

Slack thread:
Matrix thread backfilled before this change:

Preventing the

convertedMessagesslice from being reversed for threads results in threads appearing in the expected order:Matrix thread backfilled after this change: