Closed
Conversation
a9393bb to
48c0cf7
Compare
Contributor
|
Compare it to my attempt which compiles if you want: master...Ryanf55:qgroundcontrol:add-gdal-map-provider |
293ce71 to
041a367
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds PROJ and GDAL dependencies to the project, updates the installation scripts, and scaffolds a new GDALHelper utility.
- Updates macOS and Debian setup scripts to install PROJ
- Introduces empty
GDALHelperheader and source files - Integrates PROJ and GDAL via CPM in the CMakeLists
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/setup/install-dependencies-osx.sh | Added proj to the brew install line |
| tools/setup/install-dependencies-debian.sh | Added libproj-dev and proj-bin apt packages |
| src/Utilities/Shape/GDALHelper.h | Added empty GDALHelper namespace scaffold |
| src/Utilities/Shape/GDALHelper.cc | Added empty implementation file for GDALHelper |
| src/Utilities/Shape/CMakeLists.txt | Added PROJ and GDAL packages via CPM and linked GDAL |
Comments suppressed due to low confidence (6)
src/Utilities/Shape/GDALHelper.cc:17
- No tests cover the new
GDALHelperscaffolding; once methods are implemented, add unit tests to verify their behavior.
}
tools/setup/install-dependencies-osx.sh:11
- GDAL is not installed on macOS; you should include
gdal(or the appropriate formula) in the brew install line to match the new GDAL integration.
brew install cmake ninja ccache git pkgconf create-dmg mold proj
tools/setup/install-dependencies-debian.sh:116
- GDAL development libraries (
libgdal-dev) or tools (gdal-bin) are not installed; add the appropriate packages so GDAL builds correctly on Debian.
apt-get install -y -qq --no-install-recommends \
src/Utilities/Shape/CMakeLists.txt:33
- The PROJ package is added via CPM but never linked to the target; consider adding
target_link_libraries(${CMAKE_PROJECT_NAME} PRIVATE PROJ::proj)after the PROJ block.
CPMAddPackage(
src/Utilities/Shape/CMakeLists.txt:45
- [nitpick] The old
find_packageand related lines are commented out; remove or update these to keep the CMakeLists clean.
# find_package(PROJ REQUIRED CONFIG)
src/Utilities/Shape/GDALHelper.h:12
- [nitpick] The
GDALHelpernamespace is empty; consider adding at least a placeholder function declaration or a TODO comment so it's clear what belongs here.
namespace GDALHelper
0305886 to
43eadb8
Compare
43eadb8 to
35f7f25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a test