Feature/desktop mini player#1614
Conversation
|
Nice coding! |
Thank you bro |
|
Hi! I submitted a Pull Request, but the CI builds are failing because of missing secrets. Sentry Error: The build fails with Invalid token header because it's trying to upload Proguard mappings to Sentry, but I don't have the SENTRY_AUTH_TOKEN. Signing Error: The build_and_sign_apk.sh script fails because I don't have access to the release signing keys (KEY_PASSWORD, etc.). Since forks/PRs don't have access to your repository secrets, does the project require contributors to set up their own Sentry Keystore secrets just to pass CI? Or would you prefer if I modify the build scripts (e.g., in build.gradle.kts and build_and_sign_apk.sh) to gracefully skip these steps when secrets are missing? I have working fixes that fallback to debug signing and disable Sentry uploads automatically for PRs. |
32d19cf to
363f92b
Compare
…layer # Conflicts: # gradle/libs.versions.toml
This pull request introduces a cross-platform mini player toggle feature, enabling a separate mini player window on desktop (JVM) only. It adds platform-specific implementations for toggling the mini player, refactors UI components to expose the mini player toggle button on desktop, and implements the mini player window with state management and persistence. The changes ensure that the mini player functionality is desktop-exclusive, with no-ops on Android and iOS.
Mini Player Feature (Desktop Only):
toggleMiniPlayerfunction using Kotlin'sexpect/actualmechanism, with a working implementation for JVM (desktop) and no-ops for Android and iOS. [1] [2] [3] [4]MiniPlayerManagerto manage the mini player window state andMiniPlayerWindowcomposable for the separate window, including position/size persistence, always-on-top, and keyboard shortcuts. [1] [2]UI Integration:
MiniPlayerandNowPlayingScreencomponents to show a mini player toggle button on desktop, using the newtoggleMiniPlayerfunction and appropriate icons. [1] [2]Application Lifecycle & Window Management:
Dependency Update:
8.13.1to8.13.2.Perview

