Add: GitHub actions support for translated documentation.#81
Open
yestalgia wants to merge 18 commits intomcallegari:mainfrom
Open
Add: GitHub actions support for translated documentation.#81yestalgia wants to merge 18 commits intomcallegari:mainfrom
yestalgia wants to merge 18 commits intomcallegari:mainfrom
Conversation
…e' into codex/localize-title-page-for-pdf-build
…f-build Localise pdf title page during build-pdf stage of documentation action
Collaborator
Author
|
Update: I've managed to wrangle the logic for the title page to enable translations for it. @sbenejam and @jpue can you please check the actions build for the translated PDFs and let me know if they're okay? I'll quickly add a step to add the title page translation to the readme then I think we're good to go! |
Contributor
|
The english version seems ok. The catalan and german versions are not
ok. The indexes are not the same.
[image: Screenshot_20250722_191516.png]
[image: Screenshot_20250722_191557.png]
[image: Screenshot_20250722_191809.png]
Missatge de Lachlan Hicks ***@***.***> del dia dt., 22 de
jul. 2025 a les 13:04:
… *yestalgia* left a comment (mcallegari/qlcplus-docs#81)
<#81 (comment)>
Update: I've managed to wrangle the logic for the title page to enable
translations for it.
@sbenejam <https://github.com/sbenejam> and @jpue
<https://github.com/jpue> can you please check the actions build for the
translated PDFs and let me know if they're okay?
I'll quickly add a step to *add the title page translation* to the readme
then I think we're good to go!
—
Reply to this email directly, view it on GitHub
<#81 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABO5H47GCZ3K55E3RXPTBC33JYLD3AVCNFSM6AAAAACBNAYOB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBSGI2DMMBQGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
Author
I think you tried to link some screenshots but it didn't work. What do you mean sorry? |
Contributor
Collaborator
Author
Ahh good pickup. I'll investigate what's going on. |
Contributor
|
Exactly the table of contents does not work in the translated versions.
Screenshot_20250722_191516.png
<https://drive.google.com/open?id=1CTh3IHbIkeAVVKPJGRE-niK4WUcBote9>
Screenshot_20250722_191557.png
<https://drive.google.com/open?id=1uy9L6ya_QiK4aQ3ofAKxlDZO-dl1KfjD>
Missatge de jpue ***@***.***> del dia dj., 24 de jul. 2025 a
les 12:31:
… *jpue* left a comment (mcallegari/qlcplus-docs#81)
<#81 (comment)>
I think he wanted to point out that the creation of the table of contents
does not work properly for the translated versions.
qlcplus-docs-translations.png (view on web)
<https://github.com/user-attachments/assets/a0b78e8d-9eb6-4b24-9c8b-9e1c098e96e9>
—
Reply to this email directly, view it on GitHub
<#81 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABO5H44ZAKNZNEPGH4AET3L3KCYZ7AVCNFSM6AAAAACBNAYOB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMJSHEZTQNZWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request allows our documentation translations to be transformed into individual PDFs.
I now call the build-pdf action from main.yml and release.yaml in a matrix where it is passed each language code.
New functionality:
What was required:
Future plans:
Fixes: #31
I wanted to raise this PR before going into the weeds with the title page to check you're okay with everything so far @mcallegari