Add wheelPropagationDisabledIfScrollable option#145
Open
SvenSchoene wants to merge 1 commit intomdbootstrap:mainfrom
Open
Add wheelPropagationDisabledIfScrollable option#145SvenSchoene wants to merge 1 commit intomdbootstrap:mainfrom
wheelPropagationDisabledIfScrollable option#145SvenSchoene wants to merge 1 commit intomdbootstrap:mainfrom
Conversation
775c834 to
3d7b6c7
Compare
3d7b6c7 to
894785c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm testto make sure it formats and build successfullyWe have a specific use case regarding wheel propagation: When there is a container with a scroll bar, we want
wheelPropagation: false. However, when the container does not have a scroll bar, we wantwheelPropagation: true.This was not really possible to implement outside of this library.
I added three new examples for this.
Example code:
I read the contributions guide; ran the formatter; re-built the source files so that /dist is updated; updated the typescript file; and added an example.