Conversation
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 41.35% 40.77% -0.59%
==========================================
Files 13 14 +1
Lines 3794 3799 +5
==========================================
- Hits 1569 1549 -20
- Misses 2225 2250 +25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
|
TODOs:
|
Contributor
|
Putting this in draft for now until we converge on mdolab/pyspline#41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
There was concern in this pyspline PR that repos like ADflow would not be able to import the shared object library in the
__init__.pyfile like pyspline because it is normally handled byMExt. I made what seems to me to be a working example here. I think more discussion about specific formatting for this process should be done in the pyspline discussion.Expected time until merged
a couple weeks, probably want pyspline discussion done first.
Type of change
Testing
Checklist
flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted