feat: Add language translation to OpenAI recipe parser#6805
Closed
lcs-crr wants to merge 1 commit intomealie-recipes:mealie-nextfrom
Closed
feat: Add language translation to OpenAI recipe parser#6805lcs-crr wants to merge 1 commit intomealie-recipes:mealie-nextfrom
feat: Add language translation to OpenAI recipe parser#6805lcs-crr wants to merge 1 commit intomealie-recipes:mealie-nextfrom
Conversation
lcs-crr
changed the title
feat: Add language translation to OpenAI recipe parserfeat: Add language translation to OpenAI recipe parser
lcs-crr
commented
Dec 31, 2025
|
|
||
| async def parse_one(self, ingredient_string: str) -> ParsedIngredient: | ||
| items = await self.parse([ingredient_string]) | ||
| async def parse_one(self, ingredient_string: str, translate_language: str | None = None) -> ParsedIngredient: |
Author
There was a problem hiding this comment.
Could it be that this method is never called? I'm assuming it has to exist because of the abstract method in _base.py, but imo it is a bit confusing to have any logic within it beyond a raise NotImplementedError("This method is not supported.")
Author
|
No capacity to work on it :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)