Modernize various CMake designs #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one is highly discouraged to be used now
LecrisUT
commented
Apr 17, 2025
Comment on lines
+41
to
+42
| # BREAKID_STATIC_LIBRARIES_DEPS is not defined | ||
| set(BREAKID_STATIC_LIBRARIES_DEPS "") |
Author
There was a problem hiding this comment.
From this one and GitSHA1.cpp contents, I take it that you used some other project as a template. I realize it may be a chore, but could you please remove the dead references in there. I don't have the background of what this project is about so I can't do such a review.
Collaborator
|
Oh wow! This looks awesome! I'll check tonight and see if I can merge it. I'll also take note to port some of these to my other projects! This is super helpful, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to split the various changes in individual commits so that it can be more easily followed