Skip to content

Use environment flag to allow all network IPs in tests#867

Merged
norkunas merged 2 commits intomainfrom
fix/v1.34-network-tests
Feb 3, 2026
Merged

Use environment flag to allow all network IPs in tests#867
norkunas merged 2 commits intomainfrom
fix/v1.34-network-tests

Conversation

@Strift
Copy link
Collaborator

@Strift Strift commented Feb 3, 2026

Pull Request

What

Fixes #865

How

Start Meilisearch by allowing any IP to be registered in the network

PR checklist

Please check if your PR fulfills the following requirements:

  • Did you use any AI tool while implementing this PR (code, tests, docs, etc.)? If yes, disclose it in the PR description and describe what it was used for. AI usage is allowed when it is disclosed.
  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • Chores

    • Updated the search service to a newer release.
    • Expanded allowed IP networks for search service connectivity.
  • Tests

    • CI workflows updated to enable the expanded network access during test/pre-release runs.
    • Minor CI workflow formatting refinements.

@Strift Strift added the enhancement New feature or request label Feb 3, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Updated Meilisearch image in Docker Compose and added the MEILI_EXPERIMENTAL_ALLOWED_IP_NETWORKS=any environment variable across Docker Compose and GitHub Actions workflows; minor YAML quoting/style tweaks in one workflow file.

Changes

Cohort / File(s) Summary
Docker Compose
docker-compose.yml
Bumped Meilisearch image from getmeili/meilisearch-enterprise:v1.30.0 to v1.35.0 and added MEILI_EXPERIMENTAL_ALLOWED_IP_NETWORKS=any env var.
GitHub Actions — meilisearch beta tests
.github/workflows/meilisearch-beta-tests.yml
Added MEILI_EXPERIMENTAL_ALLOWED_IP_NETWORKS: any to the meilisearch service env.
GitHub Actions — pre-release tests
.github/workflows/pre-release-tests.yml
Added MEILI_EXPERIMENTAL_ALLOWED_IP_NETWORKS: any to the meilisearch service env.
GitHub Actions — tests
.github/workflows/tests.yml
Added MEILI_EXPERIMENTAL_ALLOWED_IP_NETWORKS: any to meilisearch env; minor quoting/style changes (ports mapping and matrix PHP-version quoting, coverage step strings).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

maintenance

Suggested reviewers

  • norkunas

Poem

🐰 A little rabbit hops with cheer,
Meilisearch grows newer this year.
Networks opened wide, version on the way,
Containers hum and tests can play.
Hooray for builds that run, hooray! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Use environment flag to allow all network IPs in tests' directly and clearly describes the main change: adding an environment variable (MEILI_EXPERIMENTAL_ALLOWED_IP_NETWORKS=any) across multiple test configurations to resolve network API compatibility issues.
Linked Issues check ✅ Passed The pull request addresses issue #865 by updating the Meilisearch service image from v1.30.0 to v1.35.0 and adding the MEILI_EXPERIMENTAL_ALLOWED_IP_NETWORKS environment variable across all test workflows to fix network API test failures.
Out of Scope Changes check ✅ Passed The changes are within scope: environment variable additions for network API compatibility and version updates align with fixing network tests. Minor formatting changes (quote style changes) in tests.yml are negligible and incidental.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/v1.34-network-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@docker-compose.yml`:
- Around line 20-23: Replace the misspelled Meilisearch environment variable in
the docker-compose service: change MEILI_EXPERIMENTAL_ALLOWED_IP_NETWORKS to the
correct MEILI_EXPERIMENTAL_ALLOW_IP_NETWORKS and keep the value "any" (this is
in the environment block where MEILI_MASTER_KEY and MEILI_NO_ANALYTICS are
defined).

@Strift Strift requested review from curquiza and norkunas February 3, 2026 02:39
@norkunas norkunas added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit 995ded9 Feb 3, 2026
10 checks passed
@norkunas norkunas deleted the fix/v1.34-network-tests branch February 3, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v1.34] Fix network API tests

2 participants