Use array_key_exists instead of isset in Task::offsetExists#870
Use array_key_exists instead of isset in Task::offsetExists#870norkunas wants to merge 1 commit intomeilisearch:mainfrom
array_key_exists instead of isset in Task::offsetExists#870Conversation
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
==========================================
- Coverage 89.78% 87.25% -2.53%
==========================================
Files 59 81 +22
Lines 1449 1766 +317
==========================================
+ Hits 1301 1541 +240
- Misses 148 225 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
35acd5f to
cdcac0f
Compare
Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?
issetwitharray_key_existsto respect null valuesPR checklist
Please check if your PR fulfills the following requirements:
meilisearch-php@v2meilisearch-symfony#432 (comment)Summary by CodeRabbit