Fix LiquibaseLoaderIntegrationTest#200
Open
mogoodrich wants to merge 1 commit intomekomsolutions:mainfrom
Open
Fix LiquibaseLoaderIntegrationTest#200mogoodrich wants to merge 1 commit intomekomsolutions:mainfrom
mogoodrich wants to merge 1 commit intomekomsolutions:mainfrom
Conversation
Contributor
Author
|
But now github actions is failing on this test: |
mks-d
reviewed
Jun 28, 2024
Member
mks-d
left a comment
There was a problem hiding this comment.
@mogoodrich is this still current?
Member
|
Looks like this is still necessary (i.e., we're skipping this test on GH Actions). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when running tests that the LiquibaseLoaderIntegrationTest was failing for me when running all the tests via Maven. Looking at the test, I saw a comment and some code ignoring when running github actions.
I think I figured out the error: the DeleteDomainChecksumsChangesetIntegrationTest was polluting the context somehow, and so if it happened to run before the LiquibaseLoaderIntegrationTest the latter fails.
I was able to fix it by changing the name the liquibase files used (see PR) though the "proper" fix would likely be to fix the DeleteDomain test to clean up it's context.
fyi @ibacher