Validator running against Core 2.6.9.#294
Open
Ruhanga wants to merge 3 commits intomekomsolutions:mainfrom
Open
Validator running against Core 2.6.9.#294Ruhanga wants to merge 3 commits intomekomsolutions:mainfrom
Ruhanga wants to merge 3 commits intomekomsolutions:mainfrom
Conversation
mks-d
reviewed
Feb 19, 2025
| import org.springframework.beans.factory.annotation.Qualifier; | ||
|
|
||
| public class BillableServicesLoaderIntegrationTest extends DomainBaseModuleContextSensitive_2_4_test { | ||
| public class BillableServicesLoaderIntegrationTest extends DomainBaseModuleContextSensitive_2_4_Test { |
Member
There was a problem hiding this comment.
Not sure what got changed here? There's a bunch of files with similar changesets... 🤔
Contributor
Author
There was a problem hiding this comment.
Ahh, it has to do with changing from *_test to *_Test.
Contributor
Author
@mks-d, you're correct about the Validator's promise to validate against the latest available Core version. However, this hasn't been a priority in recent times. |
Contributor
Author
|
Hi @mks-d, could there be any reservations to having this in already? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades validator to OpenMRS Core 2.6.9.
Affects: openmrs/openmrs-contrib-packager-maven-plugin#29