#303 - Support core provider roles from OpenMRS 2.8.2#304
Draft
mseaton wants to merge 1 commit intomekomsolutions:mainfrom
Draft
#303 - Support core provider roles from OpenMRS 2.8.2#304mseaton wants to merge 1 commit intomekomsolutions:mainfrom
mseaton wants to merge 1 commit intomekomsolutions:mainfrom
Conversation
Collaborator
Author
|
Marking this a draft while we re-think this. I think we will actually plan to sunset providermanagement entirely and just move to support either the existing providermanagement providerroles as-is, or core providerroles as supported by core 2.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bit tricky to implement correctly. An alternative to this could potentially be to have 3 more Maven submodules, one for api-2.8, one for providermanagement-2.x, one for providermanagement-4.x. This felt heavier to implement, though the benefit is that you can probably actually unit test against all 3 of these scenarios, unlike in this case.
This is built with the assumption that we move forward with this change to providermanagement: https://openmrs.atlassian.net/browse/PROV-112