chore: Add raise_error option to run and run_and_log methods in process.py #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
edgarrmondragon
requested changes
Feb 12, 2024
Collaborator
edgarrmondragon
left a comment
edgarrmondragon
left a comment
There was a problem hiding this comment.
@nivinsrinivas Thanks! I left a comment.
Comment on lines
+79
to
+80
| `check=True` and `raise_error=True`. This means that if the subprocess | ||
| fails a `CalledProcessError` will be raised. |
Collaborator
There was a problem hiding this comment.
Can you confirm if raise_error isn't doing anything at the moment?
Perhaps the same argument name check should be used for this method and just pass it directly to subprocess.run(..., check=check).
|
Any word on this? This is blocking other issues, namely meltano/dbt-ext#56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
📚 Documentation preview 📚: https://meltano-edk--206.org.readthedocs.build/en/206/