SPM-143690 Update nodejs default to v20 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romakarol
changed the title
EoinMan
approved these changes
Jun 9, 2025
Contributor
Author
|
Regarding the impact of removing cache: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the default node to v20 as that is a requirement on all our VMs now (qualys raises vulnerabiltiies otherwise).
We can pass in whatever version we want as a parameter but best to update this at source.
Changes
https://github.com/merative/spm-toolbox/actions/runs/15532450727
Getting an error for cache: only way around it from what I can find is to remove, or use a different version of python. Could be intermittent in theory but the molecule tests take 2.5m without it, don't think we need cache here (previous passing builds take anything from 40s to 4m so not sure what the time savings is).
Test
The provisionerwrapper is passing in this version by default and it is working:
https://spmdevops-team-apollo.jenkins.commops.merative.com/job/DevOps-Jenkins-ProvisionerWrapper/1510/parameters/