Skip to content

Conversation

@YadavAkhileshh
Copy link

Fixes #265

Current Behavior

The modal container expands in height when FAQ answers are clicked/opened, causing layout issues.

ps2.mp4

Changes

  • Added inline styles to Modal component to set fixed height (80vh) and prevent dynamic resizing
  • Updated Modal CSS to enable internal scrolling within the .content div
  • Removed redundant CSS properties that are now handled by inline styles
ps3.mp4

Solution

  • Modal now has a fixed height of 80vh with overflow: hidden
  • Only the .content div inside the modal scrolls when FAQ content expands
  • Prevents the modal from growing beyond its intended size

Signed-off-by: YadavAkhileshh yadavakhil2501@gmail.com

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @YadavAkhileshh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a layout issue where the modal container would expand unexpectedly when FAQ answers were opened, leading to a poor user experience. The solution involves centralizing the modal's sizing and positioning logic using inline styles in the App.js component, setting a fixed height and preventing the modal from growing. Concurrently, the internal content area of the modal is now configured to handle its own scrolling, ensuring that the modal's overall dimensions remain stable regardless of its content.

Highlights

  • Modal Sizing Control: Implemented inline styles on the Modal component in App.js to enforce a fixed height of 80vh and prevent dynamic resizing, ensuring the modal maintains a consistent size.
  • Internal Content Scrolling: Modified the CSS in index.style.js to enable vertical scrolling specifically within the .content div of the modal, ensuring that only the content scrolls, not the modal itself.
  • CSS Refactoring: Removed redundant CSS properties from the .Modal class in index.style.js as these styles are now managed directly via inline styles in the App.js component, streamlining the styling approach.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@YadavAkhileshh
Copy link
Author

YadavAkhileshh commented Dec 25, 2025

@saurabhraghuvanshii @kishore08-07 Please check my PR and review it

@netlify
Copy link

netlify bot commented Dec 25, 2025

Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit a0d5ee1
🔍 Latest deploy log https://app.netlify.com/projects/meshery-play/deploys/6968baab6f97eb0008fb81c9
😎 Deploy Preview https://deploy-preview-276--meshery-play.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves the issue of the modal container expanding when FAQ answers are opened. The approach of setting a fixed height on the modal and enabling scrolling on the inner content is correct.

My review focuses on improving the maintainability of the styling changes. I've suggested moving the inline styles from the App.js component into the index.style.js stylesheet. This follows best practices by separating concerns and centralizing style definitions, which will make future updates easier. The proposed changes preserve the functional fix while enhancing the code structure.

Copy link
Member

@kishore08-07 kishore08-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YadavAkhileshh Please incorporate Gemini’s suggestions and clean up any unused CSS in your changes.

@YadavAkhileshh YadavAkhileshh force-pushed the fix/modal-container-expansion branch from a16002e to 65695c8 Compare January 15, 2026 09:58
Fixes meshery#265

Signed-off-by: YadavAkhileshh <yadavakhil2501@gmail.com>
@YadavAkhileshh YadavAkhileshh force-pushed the fix/modal-container-expansion branch from 65695c8 to a0d5ee1 Compare January 15, 2026 10:00
@YadavAkhileshh
Copy link
Author

@kishore08-07 please review it

Copy link
Member

@kishore08-07 kishore08-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YadavAkhileshh , LGTM.

@YadavAkhileshh
Copy link
Author

@Rajesh-Nagarajan-11 This is ready for merge. Please proceed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Conatiner size

3 participants