-
Notifications
You must be signed in to change notification settings - Fork 131
fix: Prevent modal container expansion when FAQ answers are opened #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: Prevent modal container expansion when FAQ answers are opened #276
Conversation
Summary of ChangesHello @YadavAkhileshh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a layout issue where the modal container would expand unexpectedly when FAQ answers were opened, leading to a poor user experience. The solution involves centralizing the modal's sizing and positioning logic using inline styles in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@saurabhraghuvanshii @kishore08-07 Please check my PR and review it |
✅ Deploy Preview for meshery-play ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively resolves the issue of the modal container expanding when FAQ answers are opened. The approach of setting a fixed height on the modal and enabling scrolling on the inner content is correct.
My review focuses on improving the maintainability of the styling changes. I've suggested moving the inline styles from the App.js component into the index.style.js stylesheet. This follows best practices by separating concerns and centralizing style definitions, which will make future updates easier. The proposed changes preserve the functional fix while enhancing the code structure.
kishore08-07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YadavAkhileshh Please incorporate Gemini’s suggestions and clean up any unused CSS in your changes.
a16002e to
65695c8
Compare
Fixes meshery#265 Signed-off-by: YadavAkhileshh <yadavakhil2501@gmail.com>
65695c8 to
a0d5ee1
Compare
|
@kishore08-07 please review it |
kishore08-07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @YadavAkhileshh , LGTM.
|
@Rajesh-Nagarajan-11 This is ready for merge. Please proceed |
Fixes #265
Current Behavior
The modal container expands in height when FAQ answers are clicked/opened, causing layout issues.
ps2.mp4
Changes
ps3.mp4
Solution
Signed-off-by: YadavAkhileshh yadavakhil2501@gmail.com