Refine Schemas Code Contributor Agent Definition

[1012Charan]

Description

Refines the existing schemas agent into a complete, blueprint-level definition in .github/agents/code-contributor.md.

Changes

• Strict guardrails: Hard rules against editing or committing generated files (models/, typescript/generated/, dist/, openapi/build/).
• Core patterns: Enforces reuse of v1alpha1/core types and x-order for field ordering.
• Workflow guides: Step-by-step flows for adding new constructs and modifying existing schemas.
• Quality gates: Pre-commit checklist for build success, clean git status, and signed commits.
• Self-verification: Requires the agent to re-run build, lint, and template checks until the repository is clean.

Replaces the previous, incomplete schemas-code-contributor.md agent definition.

This PR fixes #583

Signed commits

• Yes, I signed my commits.

[gemini-code-assist]

Summary of Changes

Hello @1012Charan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the definition of the Meshery Schemas Code Contributor agent, providing a comprehensive blueprint for its operation within the meshery/schemas repository. It establishes clear guidelines for schema development, including explicit rules for managing generated code, standardizing schema patterns, outlining detailed workflows for adding and modifying schemas, and implementing a robust pre-commit checklist to ensure code quality and consistency. This refinement aims to streamline schema development and maintain data integrity across the Meshery ecosystem.

Highlights

• Strict Guardrails: Hard rules have been established against editing or committing generated files, including those in models/, typescript/generated/, dist/, and openapi/build/.
• Core Patterns Enforcement: The agent definition now enforces the reuse of v1alpha1/core types and the use of x-order for consistent field ordering in schemas.
• Workflow Guides: Step-by-step flows are provided for adding new constructs and modifying existing schemas, ensuring a standardized approach to development.
• Quality Gates: A comprehensive pre-commit checklist has been introduced, covering build success, clean Git status, and signed commits to maintain code quality.
• Self-Verification: The agent is now required to re-run build, lint, and template checks until the repository is clean, promoting automated quality assurance.
• Agent Definition Replacement: This pull request replaces the previous, incomplete schemas-code-contributor.md agent definition with a more complete and refined version.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request significantly refines the schemas code contributor agent definition, providing a much more detailed and comprehensive guide. The new code-contributor.md is well-structured and covers the essential workflows and constraints for contributing to the meshery/schemas repository.

I've identified a couple of inaccuracies in the instructions that could lead to confusion or incorrect actions by the agent. My feedback includes a correction for a redundant build command and a clarification on the process for updating TypeScript exports, which is currently incomplete. Addressing these points will make the agent definition even more robust and reliable.

[gemini-code-assist]

The instructions for updating typescript/index.ts are incomplete and could lead to an incorrect public API for the TypeScript package. The current example misses importing the schema file, exporting it, and does not mention adding the type to a versioned namespace.

A more accurate set of instructions should guide the agent to perform these actions, as shown in CONTRIBUTING.md and the existing typescript/index.ts file.

Here is a more complete example of the changes needed in typescript/index.ts that should be reflected in the agent's instructions:

// 1. Add new imports for the construct
import { components as NewComponents } from "./generated/v1beta1/<construct>/<Construct>";
import NewConstructSchema from "./generated/v1beta1/<construct>/<Construct>Schema";

// ... other imports

// 2. Add the new schema to the main export block
export {
  // ... existing schemas
  NewConstructSchema,
};

// ...

// 3. Add the new type to the versioned namespace
export namespace v1beta1 {
  // ... existing types
  export type <Construct> = NewComponents["schemas"]["<Construct>Definition"];
}

Please update the agent definition to reflect this more detailed process.

[gemini-code-assist]

The make setup command already includes npm install, so running npm install again is redundant. The instruction should be simplified to just make setup to avoid confusion and unnecessary work for the agent.

Suggested change

	make setup && npm install # Install all dependencies (first time)
	make setup # Install all dependencies (first time)

[leecalcote]

Meshery CLI, MeshKit, Meshery Adapters... other ecosystem components.