Conversation
github-actions
bot
added
the
size/XXL
mesosphere-ci
added
applications/grafana-loki
applications/project-grafana-loki
ok-to-test
|
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/loki-helm-3.0.x |
Pull Request Test Coverage Report for Build 21939748653Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
can you add a online liner in the grafana-loki regarding deprication |
| - name: grafana-loki-v3-pre-install | ||
| force: true | ||
| prune: true | ||
| interval: 6h |
There was a problem hiding this comment.
wait: true is missing , is this intentional and if yes , why ?
| kind: GitRepository | ||
| name: management | ||
| namespace: kommander-flux | ||
| timeout: 15m |
There was a problem hiding this comment.
why 15min timeout ? old loki had 1min
| postBuild: | ||
| substitute: | ||
| appVersion: ${appVersion} | ||
| releaseNamespace: ${releaseNamespace} |
There was a problem hiding this comment.
releaseName: ${releaseName} is missing
| - airgapped | ||
| overview: |- | ||
| # Note | ||
| This Application is Deprecated. |
There was a problem hiding this comment.
"This Application is Deprecated, and is replaced by a seprate Grafana Loki application/"
| project-grafana-loki-v3: | ||
| enabled: true | ||
| enableOBCHealthCheck: false | ||
| bucketName: proj-loki-v3-${releaseNamespace} |
There was a problem hiding this comment.
can you confirm if these fields are been read by the object-bucket-claim chart or if they only look for project-grafana-loki
There was a problem hiding this comment.
Chart Template is like below:
{{- range $app, $config := .Values.dkp }}
{{- if $config.enabled }}
So, key (here project-grafana-loki-v3) doesn't matter, it just iterates and checks if enabled is true, then create bucket with name provided in bucketName
| aws: | ||
| s3: "http://rook-ceph-rgw-dkp-object-store.${workspaceNamespace}.svc:80/proj-loki-v3-${releaseNamespace}" | ||
| s3forcepathstyle: true |
There was a problem hiding this comment.
is this part required when its already defined in storage:
s3:
endpoint: "http://rook-ceph-rgw-dkp-object-store.${workspaceNamespace}.svc:80"
s3ForcePathStyle: true
insecure: true
There was a problem hiding this comment.
The boltdb-shipper index store needs the storage_config.aws.s3 URL format with the bucket name embedded in the path. The new chart's loki.storage section doesn't generate this format - it's designed for newer storage backends like TSDB
| spec: | ||
| force: true | ||
| prune: true | ||
| interval: 6h |
There was a problem hiding this comment.
wait: true is missing , and timeout should be 1 min
| - airgapped | ||
| overview: |- | ||
| # Note | ||
| This Application is Deprecated. |
There was a problem hiding this comment.
This Application is Deprecated, and is replaced by a separate Grafana Loki.
5 participants
What problem does this PR solve?:
Loki application with helm chart 3.0.x
Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-111693