Improve readability of PixelShuffle operation in Llama4#304
Improve readability of PixelShuffle operation in Llama4#304Yuki-Imajuku wants to merge 1 commit intometa-llama:mainfrom
Conversation
|
Hi @Yuki-Imajuku! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
This PR improves the readability of the
pixel_shuffle_op()function within llama_models/llama4/vision/embedding.py.Previously, the input tensor dimensions were unpacked as$[N, H, W, C]$ , this PR aligns the naming accordingly.
n, w, h, c = input_x.size(), but since the tensor dimensions withinPixelShuffle.forward()are expected to beSince the implementation assumes a square patch input, this change does not affect the underlying logic and is strictly for readability enhancement.
Additionally, the type annotation for ps_ratio has been added because it differs slightly from
torch.nn.PixelShuffleby accepting afloat.