Modified copyright, privacy, terms in docs#1160
Modified copyright, privacy, terms in docs#1160mollyxu wants to merge 3 commits intometa-pytorch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
| </script> | ||
|
|
||
| <script type="text/javascript"> | ||
| // Override footer links to Meta's Terms and Privacy Policy |
There was a problem hiding this comment.
Currently, we use pytorch-sphinx-theme, which have these links to privacy and terms in raw html. We can't directly override it in our layout.html. As such, we would have to use javascript to replace those links.
We could also ask pytorch-sphinx-theme if they could wrap these links in an overridable block but Im not sure if it makes sense for them to support that.
There was a problem hiding this comment.
I think the search and replace approach makes sense, but is somewhat fragile. If the pytorch_sphinx_theme footer updates, we will no longer update the link to have the correct policy.
The fix should probably be upstream, where this link is currently set.
docs/source/conf.py
Outdated
|
|
||
| # General information about the project. | ||
| copyright = "2023-present, TorchCodec Contributors" | ||
| copyright = "©2023 Meta Platforms, Inc" |
There was a problem hiding this comment.
Meta Open Source policy has a script regex that requires the copyright symbol to appear after "Copyright." This will result in a double copyright symbol effectively and render as © Copyright ©2023 Meta Platforms, Inc.The official PyTorch docs also have a double copyright symbol
Alternatively, we could replace the footer's copyright section using JavaScript
There was a problem hiding this comment.
It seems on the official pytorch docs, the first copyright symbol precedes "PyTorch", but ours only precedes the word "Copyright"?
'© PyTorch. Copyright © The Linux Foundation®'
Either way, it's probably fine to have two copyright symbols.
Torchaudio keeps the year current, lets reuse this code: https://github.com/pytorch/audio/blob/e1232690308a6b5297fcd06e925899a9b64f7280/docs/source/conf.py#L174
2 participants
Modified copyright, privacy, terms in homepage to comply with Meta Open Source policies