Find muxer options in VideoEncoder to test fragmented mp4#1216
Open
Dan-Flores wants to merge 7 commits intometa-pytorch:mainfrom
Open
Find muxer options in VideoEncoder to test fragmented mp4#1216Dan-Flores wants to merge 7 commits intometa-pytorch:mainfrom
Dan-Flores wants to merge 7 commits intometa-pytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1216
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4b4bf72 with merge base 06d4538 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…o fragmented_mp4_perhaps
This reverts commit c35d1e8.
Dan-Flores
commented
Feb 3, 2026
| // https://github.com/FFmpeg/FFmpeg/blob/n8.0/libavformat/movenc.c#L8666 | ||
| if (status > 0) { | ||
| status = AVSUCCESS; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Without this conversion, we interpret the positive returned integer as a random low level error unrelated to the encoding process (ex. 24 raises EMFILE: too many open files). It might just be a bug in the FFmpeg implementation that we can work around.
Since FFmpeg errors are negative, I think its fine to set the status to successful here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logic to
sortCodecOptionsto find and set muxer options (check available options withffmpeg -h muxer=mp4)With these changes, we can now test that fragment related
movflagoptions are utilized correctly.But, without a 'streaming' video encoder, the benefits of fragmented mp4's are still not unlocked: