Skip to content

Fix for unload listener breaking bfcache / making Pagespeed Lighthouse warnings #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonhassall wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix for unload listener breaking bfcache / making Pagespeed Lighthouse warnings #991

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f1a1bf
Change unload listener to use pagehide, to reduce inteference with bf…
jonhassall Feb 4, 2026
801c02b
Built dist files for "Change unload listener to use pagehide, to redu…
jonhassall Feb 4, 2026
590deb5
Revert "Built dist files for "Change unload listener to use pagehide,…
jonhassall Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions js/history.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ proto.createHistoryAppend = function() {
this.scrollPage = this.scrollPages[0];
// events
this.scrollHistoryHandler = this.onScrollHistory.bind( this );
this.unloadHandler = this.onUnload.bind( this );
this.pagehideHandler = this.onPagehide.bind( this );
this.scroller.addEventListener( 'scroll', this.scrollHistoryHandler );
this.on( 'append', this.onAppendHistory );
this.bindHistoryAppendEvents( true );
Expand All @@ -77,7 +77,7 @@ proto.createHistoryAppend = function() {
proto.bindHistoryAppendEvents = function( isBind ) {
let addRemove = isBind ? 'addEventListener' : 'removeEventListener';
this.scroller[ addRemove ]( 'scroll', this.scrollHistoryHandler );
window[ addRemove ]( 'unload', this.unloadHandler );
window[ addRemove ]( 'pagehide', this.pagehideHandler );
};

proto.createHistoryPageLoad = function() {
Expand Down Expand Up @@ -160,7 +160,7 @@ proto.setHistory = function( title, path ) {

// scroll to top to prevent initial scroll-reset after page refresh
// https://stackoverflow.com/a/18633915/182183
proto.onUnload = function() {
proto.onPagehide = function() {
if ( this.scrollPage.top === 0 ) return;

// calculate where scroll position would be on refresh
Expand Down