Locking timeout #24
Open
Locking timeout #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This PR should not contain commits not related to timeout. |
anton-iskryzhytskyi
force-pushed
the
locking-timeout
branch
from
83bca61 to
b46ab15
Compare
Author
|
Updated, ready for review, @tshemsedinov |
Member
tshemsedinov
left a comment
tshemsedinov
left a comment
There was a problem hiding this comment.
Maybe we need to use clearTimeout on abort?
web-locks.js
Outdated
| } | ||
|
|
||
| enter(handler) { | ||
| enter(handler, timeout) { |
Member
There was a problem hiding this comment.
That it much better, but we need to compare passing timeout and timer instance.
Author
There was a problem hiding this comment.
Maybe we need to use
clearTimeouton abort?
Hmm, maybe it would be better to throw an error on timeout, similar to abort behavior?
Also, move all resolve / reject invocations to one place.
specify imported file extensions
Member
|
You are doing good code but mixing multiple changes into one PR, we need to talk about process. |
Comment on lines
+57
to
+58
| if (timeout) | ||
| timer = setTimeout(finalize, timeout, new TimeoutError('Time Out')); |
Member
There was a problem hiding this comment.
Suggested change
| if (timeout) | |
| timer = setTimeout(finalize, timeout, new TimeoutError('Time Out')); | |
| if (timeout) { | |
| timer = setTimeout(finalize, timeout, new TimeoutError('Time Out')); | |
| } |
anton-iskryzhytskyi
added a commit
to anton-iskryzhytskyi/web-locks
that referenced
this pull request
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #16