-
Notifications
You must be signed in to change notification settings - Fork 180
Refactor FederatedCredentials e2e test to use stable repository (currently disabled) #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…repository Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
…rove pagination and timestamp comparison Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
…federated credentials Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
mazhelez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
@copilot the following script is used in a workflow to clean up temp repositories: "Internal\Scripts\RemoveTempRepos.ps1"
Can you adjust the script or rename the repository, so that it doesn't get deleted?
…function, exclude tmp-bingmaps from cleanup Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Done. Updated |
…ce to avoid auto-cleanup Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
mazhelez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there.
@copilot can you please also remove trailing whitespaces?
…aces Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
…h repo clone Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
|
@copilot can you please resolve the merge conflicts? |
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
Co-authored-by: mazhelez <43066499+mazhelez@users.noreply.github.com>
❔What, Why & How
Federated credentials require stable repository identity. Refactored the test to reuse
e2e-bingmaps.appsourceinstead of deleting/recreatingtmp-bingmaps.appsourceon each run. Test is currently disabled in the workflow pending Azure resource migration.Helper functions added to
e2eTestHelper.psm1:CleanupWorkflowRuns: Deletes all workflow runs in a repository (ensures clean tracking state)ResetRepositoryToSource: Hard resets repository content to match source viagit reset --hard+ force push (preserves identity, resets content)Test flow changes in
scenarios/FederatedCredentials/runtest.ps1:tmp-bingmaps.appsource→e2e-bingmaps.appsource(avoidstmp*cleanup pattern)bcsamples-bingmaps.appsourcecontent before each runghTokenWorkflowSecretName) after resetWorkflow changes in
.github/workflows/E2E.yaml:FederatedCredentialsfrom scenario matrix (temporarily disabled)Technical details:
-- --quietflag fromgh repo cloneWhen re-enabled, the test will use the stable repository instead of recreating it, maintaining federated credential authentication.
✅ Checklist
Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.