User/ujsrivastava/block unblock device test spec by ASPS002 · Pull Request #672 · microsoft/HydraLab

ASPS002 · 2025-02-19T09:47:03Z

Description

This Pull Request adds two properties to the requestHydraLabTest test configuation for blocking and unblocking a device on which the test runs.

Blocking a device by a task
Input:
A boolean property blockDevice needs to be provided in the requestHydraLabTest Gradle task input. When it is passed as true, the deviceIdentifier passed in the task is blocked as follows:

If the deviceeIdentifier corresponds to a device group, then it blocks any one of the available online unblocked devices from the device group and the test runs on that device.
If the deviceIdentifier corresponds to a specific device, then it blocks that specific device and the test runs on that specific device.

Output:

Outputs BlockedDeviceSerialNumber that can be used in the next task and used for further task runs on the same device or any further actions.
Outputs UnblockDeviceSecretKey that can be used in the next task in which you want to unblock the device usinig this secret key.

Unblocking a device by a task
Input:
A boolean property unblockDevice and unblockDeviceSecretKey needs to be provided in the requestHydraLabTest Gradle task input. When the unblockDevice is passed as true and unblockDeviceSecretKey is not empty , then the deviceIdentifier passed in the task is unblocked as follows:

The deviceIdentifier should correspond to a specific device and not a group, if so it then runs task on that device and unblocks that specific device , so that it can be used again by other tasks.

Unblocking frozen blocked devices
Automatically unblocking of the devices which have been blocked for more than 4 hours. The default time for unblocking a device is taken as 4 hours for now.

Usecase
This is useful in cases when you want to run multiple tasks on the same device one after the other.

typeSpecificParamCheck
Added the following type specific param check for runningType INSTRUMENTATION:

Added check that a task should not set both unblockDevice and blockDevice as true in the same task as this is always true by default and redundant.
Added check that when unblockDevice is set to true the value of unblockDeviceSecretKey should not be empty as it is required to unblock a specific device blocked by a specific task.
Added check that when unblockDevice is set to true the value of deviceIdentifier passed for blocking should not be a group and instead it should be a specific device serial number.

Linked GitHub issue ID: #673

Pull Request Checklist

Tests for the changes have been added (for bug fixes / features)
Code compiles correctly with all tests are passed.
I've read the contributing guide and followed the recommended practices.
Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

Yes
No

How you tested it

Tested it on the center side by sending a POST api api/test/task/run with required parameters. It successfully blocks and unblocks the device successfully. This can be validated from the test task id as well. Here are the screenshots of the same.

Blocking:

Unblocking:

Run task on a blocked device again:

Blocking unblocking in the same test task should throw Exception:

Unblocking a device but no/empty secret key passed to unblock the device should throw exception:

Unblocking a device but deviceIdentifier of a group is passed should throw exception:

Please check the type of change your PR introduces:

Bugfix
Feature
Technical design
Build related changes
Refactoring (no functional changes, no api changes)
Code style update (formatting, renaming) or Documentation content changes
Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

… methods in DeviceAgentManagementService to handle blocking and unblocking a device and releasing any frozen blocked devices

…ame test task. Added block device by specific device Identifier

…eIdentifier is a group. Also changed the name of output variable unblockDeviceSecretKey to UnblockDeviceSecretKey

ASPS002 · 2025-02-19T10:34:33Z

@microsoft-github-policy-service agree company="Microsoft"

@ASPS002 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

center/src/main/java/com/microsoft/hydralab/center/service/TestTaskService.java

center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java

rakirs2 · 2025-02-24T13:59:54Z

Please unsubscribe me from your mailing list

…

On Mon, Feb 24, 2025 at 1:59 AM Le Zhou ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In center/src/main/java/com/microsoft/hydralab/center/service/TestTaskService.java <#672 (comment)>: > relatedIdentifiers.addAll(deviceAgentManagementService.queryDeviceByGroup(deviceIdentifier)); } else { + if (deviceAgentManagementService.isDeviceBlocked(deviceIdentifier)) { + logger.warn("Device " + deviceIdentifier + " is blocked currently."); + return false; + } Here would always return false if pass the blocked device serial, you may need to add another condition here. Such as check blockDevice image.png (view on web) <https://github.com/user-attachments/assets/57ec5840-f708-429c-a891-073684d1f491> ------------------------------ In center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java <#672 (comment)>: > @@ -957,23 +978,34 @@ private JSONObject runTestTaskByGroup(TestTaskSpec testTaskSpec) { } private JSONObject runTestTaskByDevice(TestTaskSpec testTaskSpec) { + if (testTaskSpec.unblockDevice) { If the user wants to block the device and then run 3 tasks, an error will occur. Secret detection and unlocking the device should be separated. — Reply to this email directly, view it on GitHub <#672 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADU3GOU7A7DZ5ZOPM47MRZD2RLGPHAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZWGE4TMOJTGI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

girmaw · 2025-02-24T14:10:25Z

same here - please unsubscribe me from your mailing list.

…

On Mon, Feb 24, 2025 at 5:07 PM Srikar ***@***.***> wrote: Please unsubscribe me from your mailing list On Mon, Feb 24, 2025 at 1:59 AM Le Zhou ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > center/src/main/java/com/microsoft/hydralab/center/service/TestTaskService.java > < #672 (comment)>: > > > relatedIdentifiers.addAll(deviceAgentManagementService.queryDeviceByGroup(deviceIdentifier)); > } else { > + if (deviceAgentManagementService.isDeviceBlocked(deviceIdentifier)) { > + logger.warn("Device " + deviceIdentifier + " is blocked currently."); > + return false; > + } > > Here would always return false if pass the blocked device serial, you may > need to add another condition here. Such as check blockDevice > image.png (view on web) > < https://github.com/user-attachments/assets/57ec5840-f708-429c-a891-073684d1f491> > ------------------------------ > > In > center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java > < #672 (comment)>: > > > @@ -957,23 +978,34 @@ private JSONObject runTestTaskByGroup(TestTaskSpec testTaskSpec) { > } > > private JSONObject runTestTaskByDevice(TestTaskSpec testTaskSpec) { > + if (testTaskSpec.unblockDevice) { > > If the user wants to block the device and then run 3 tasks, an error > will occur. Secret detection and unlocking the device should be separated. > > — > Reply to this email directly, view it on GitHub > < #672 (review)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ADU3GOU7A7DZ5ZOPM47MRZD2RLGPHAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZWGE4TMOJTGI> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > — Reply to this email directly, view it on GitHub <#672 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACLJZCAZYTYHKY36STBLCKT2RMRSJAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGQ4TQMBRHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> [image: rakirs2]*rakirs2* left a comment (microsoft/HydraLab#672) <#672 (comment)> Please unsubscribe me from your mailing list On Mon, Feb 24, 2025 at 1:59 AM Le Zhou ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > center/src/main/java/com/microsoft/hydralab/center/service/TestTaskService.java > < #672 (comment)>: > > > relatedIdentifiers.addAll(deviceAgentManagementService.queryDeviceByGroup(deviceIdentifier)); > } else { > + if (deviceAgentManagementService.isDeviceBlocked(deviceIdentifier)) { > + logger.warn("Device " + deviceIdentifier + " is blocked currently."); > + return false; > + } > > Here would always return false if pass the blocked device serial, you may > need to add another condition here. Such as check blockDevice > image.png (view on web) > < https://github.com/user-attachments/assets/57ec5840-f708-429c-a891-073684d1f491> > ------------------------------ > > In > center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java > < #672 (comment)>: > > > @@ -957,23 +978,34 @@ private JSONObject runTestTaskByGroup(TestTaskSpec testTaskSpec) { > } > > private JSONObject runTestTaskByDevice(TestTaskSpec testTaskSpec) { > + if (testTaskSpec.unblockDevice) { > > If the user wants to block the device and then run 3 tasks, an error > will occur. Secret detection and unlocking the device should be separated. > > — > Reply to this email directly, view it on GitHub > < #672 (review)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ADU3GOU7A7DZ5ZOPM47MRZD2RLGPHAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZWGE4TMOJTGI> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > — Reply to this email directly, view it on GitHub <#672 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACLJZCAZYTYHKY36STBLCKT2RMRSJAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGQ4TQMBRHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

shaleen · 2025-02-24T14:17:22Z

Repo owners: Please figure out how to set up notifications properly and stop sending notifications.

losamig · 2025-02-24T14:19:24Z

Same for me

…

On Mon, 24 Feb 2025 at 15:14, girmaw ***@***.***> wrote: same here - please unsubscribe me from your mailing list. On Mon, Feb 24, 2025 at 5:07 PM Srikar ***@***.***> wrote: > Please unsubscribe me from your mailing list On Mon, Feb 24, > 2025 at 1:59 AM Le Zhou ***@***.***&gt; wrote: &gt; ***@***.**** > commented on this pull request. &gt; ------------------------------ > &gt; &gt; In &gt; > center/src/main/java/com/microsoft/hydralab/center/service/TestTaskService.java > &gt; &lt; > #672 (comment)&gt;: > &gt; &gt; &gt; > relatedIdentifiers.addAll(deviceAgentManagementService.queryDeviceByGroup(deviceIdentifier)); > &gt; } else { &gt; + if > (deviceAgentManagementService.isDeviceBlocked(deviceIdentifier)) { > &gt; + logger.warn(&quot;Device &quot; + deviceIdentifier + &quot; is > blocked currently.&quot;); &gt; + return false; &gt; + } > &gt; &gt; Here would always return false if pass the blocked device > serial, you may &gt; need to add another condition here. Such as check > blockDevice &gt; image.png (view on web) &gt; &lt; > https://github.com/user-attachments/assets/57ec5840-f708-429c-a891-073684d1f491&gt; > &gt; ------------------------------ &gt; &gt; In &gt; > center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java > &gt; &lt; > #672 (comment)&gt;: > &gt; &gt; &gt; @@ -957,23 +978,34 @@ private JSONObject > runTestTaskByGroup(TestTaskSpec testTaskSpec) { &gt; } &gt; > &gt; private JSONObject runTestTaskByDevice(TestTaskSpec testTaskSpec) { > &gt; + if (testTaskSpec.unblockDevice) { &gt; &gt; If the > user wants to block the device and then run 3 tasks, an error &gt; > will occur. Secret detection and unlocking the device should be separated. > &gt; &gt; — &gt; Reply to this email directly, view it on > GitHub &gt; &lt; > #672 (review)&gt;, > &gt; or unsubscribe &gt; &lt; > https://github.com/notifications/unsubscribe-auth/ADU3GOU7A7DZ5ZOPM47MRZD2RLGPHAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZWGE4TMOJTGI&gt; > &gt; . &gt; You are receiving this because you are subscribed to > this thread.Message &gt; ID: ***@***.***&gt; &gt; > > — > Reply to this email directly, view it on GitHub > < #672 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ACLJZCAZYTYHKY36STBLCKT2RMRSJAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGQ4TQMBRHE> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > [image: rakirs2]*rakirs2* left a comment (microsoft/HydraLab#672) > < #672 (comment)> > Please unsubscribe me from your mailing list On Mon, Feb 24, > 2025 at 1:59 AM Le Zhou ***@***.***&gt; wrote: &gt; ***@***.**** > commented on this pull request. &gt; ------------------------------ > &gt; &gt; In &gt; > center/src/main/java/com/microsoft/hydralab/center/service/TestTaskService.java > &gt; &lt; > #672 (comment)&gt;: > &gt; &gt; &gt; > relatedIdentifiers.addAll(deviceAgentManagementService.queryDeviceByGroup(deviceIdentifier)); > &gt; } else { &gt; + if > (deviceAgentManagementService.isDeviceBlocked(deviceIdentifier)) { > &gt; + logger.warn(&quot;Device &quot; + deviceIdentifier + &quot; is > blocked currently.&quot;); &gt; + return false; &gt; + } > &gt; &gt; Here would always return false if pass the blocked device > serial, you may &gt; need to add another condition here. Such as check > blockDevice &gt; image.png (view on web) &gt; &lt; > https://github.com/user-attachments/assets/57ec5840-f708-429c-a891-073684d1f491&gt; > &gt; ------------------------------ &gt; &gt; In &gt; > center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java > &gt; &lt; > #672 (comment)&gt;: > &gt; &gt; &gt; @@ -957,23 +978,34 @@ private JSONObject > runTestTaskByGroup(TestTaskSpec testTaskSpec) { &gt; } &gt; > &gt; private JSONObject runTestTaskByDevice(TestTaskSpec testTaskSpec) { > &gt; + if (testTaskSpec.unblockDevice) { &gt; &gt; If the > user wants to block the device and then run 3 tasks, an error &gt; > will occur. Secret detection and unlocking the device should be separated. > &gt; &gt; — &gt; Reply to this email directly, view it on > GitHub &gt; &lt; > #672 (review)&gt;, > &gt; or unsubscribe &gt; &lt; > https://github.com/notifications/unsubscribe-auth/ADU3GOU7A7DZ5ZOPM47MRZD2RLGPHAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZWGE4TMOJTGI&gt; > &gt; . &gt; You are receiving this because you are subscribed to > this thread.Message &gt; ID: ***@***.***&gt; &gt; > > — > Reply to this email directly, view it on GitHub > < #672 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ACLJZCAZYTYHKY36STBLCKT2RMRSJAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGQ4TQMBRHE> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > — Reply to this email directly, view it on GitHub <#672 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJIQGE2B27ID4TNSWJRWMT2RMSNJAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGUZDQMRUGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> [image: girmaw]*girmaw* left a comment (microsoft/HydraLab#672) <#672 (comment)> same here - please unsubscribe me from your mailing list. On Mon, Feb 24, 2025 at 5:07 PM Srikar ***@***.***> wrote: > Please unsubscribe me from your mailing list On Mon, Feb 24, > 2025 at 1:59 AM Le Zhou ***@***.***&gt; wrote: &gt; ***@***.**** > commented on this pull request. &gt; ------------------------------ > &gt; &gt; In &gt; > center/src/main/java/com/microsoft/hydralab/center/service/TestTaskService.java > &gt; &lt; > #672 (comment)&gt;: > &gt; &gt; &gt; > relatedIdentifiers.addAll(deviceAgentManagementService.queryDeviceByGroup(deviceIdentifier)); > &gt; } else { &gt; + if > (deviceAgentManagementService.isDeviceBlocked(deviceIdentifier)) { > &gt; + logger.warn(&quot;Device &quot; + deviceIdentifier + &quot; is > blocked currently.&quot;); &gt; + return false; &gt; + } > &gt; &gt; Here would always return false if pass the blocked device > serial, you may &gt; need to add another condition here. Such as check > blockDevice &gt; image.png (view on web) &gt; &lt; > https://github.com/user-attachments/assets/57ec5840-f708-429c-a891-073684d1f491&gt; > &gt; ------------------------------ &gt; &gt; In &gt; > center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java > &gt; &lt; > #672 (comment)&gt;: > &gt; &gt; &gt; @@ -957,23 +978,34 @@ private JSONObject > runTestTaskByGroup(TestTaskSpec testTaskSpec) { &gt; } &gt; > &gt; private JSONObject runTestTaskByDevice(TestTaskSpec testTaskSpec) { > &gt; + if (testTaskSpec.unblockDevice) { &gt; &gt; If the > user wants to block the device and then run 3 tasks, an error &gt; > will occur. Secret detection and unlocking the device should be separated. > &gt; &gt; — &gt; Reply to this email directly, view it on > GitHub &gt; &lt; > #672 (review)&gt;, > &gt; or unsubscribe &gt; &lt; > https://github.com/notifications/unsubscribe-auth/ADU3GOU7A7DZ5ZOPM47MRZD2RLGPHAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZWGE4TMOJTGI&gt; > &gt; . &gt; You are receiving this because you are subscribed to > this thread.Message &gt; ID: ***@***.***&gt; &gt; > > — > Reply to this email directly, view it on GitHub > < #672 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ACLJZCAZYTYHKY36STBLCKT2RMRSJAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGQ4TQMBRHE> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > [image: rakirs2]*rakirs2* left a comment (microsoft/HydraLab#672) > < #672 (comment)> > Please unsubscribe me from your mailing list On Mon, Feb 24, > 2025 at 1:59 AM Le Zhou ***@***.***&gt; wrote: &gt; ***@***.**** > commented on this pull request. &gt; ------------------------------ > &gt; &gt; In &gt; > center/src/main/java/com/microsoft/hydralab/center/service/TestTaskService.java > &gt; &lt; > #672 (comment)&gt;: > &gt; &gt; &gt; > relatedIdentifiers.addAll(deviceAgentManagementService.queryDeviceByGroup(deviceIdentifier)); > &gt; } else { &gt; + if > (deviceAgentManagementService.isDeviceBlocked(deviceIdentifier)) { > &gt; + logger.warn(&quot;Device &quot; + deviceIdentifier + &quot; is > blocked currently.&quot;); &gt; + return false; &gt; + } > &gt; &gt; Here would always return false if pass the blocked device > serial, you may &gt; need to add another condition here. Such as check > blockDevice &gt; image.png (view on web) &gt; &lt; > https://github.com/user-attachments/assets/57ec5840-f708-429c-a891-073684d1f491&gt; > &gt; ------------------------------ &gt; &gt; In &gt; > center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java > &gt; &lt; > #672 (comment)&gt;: > &gt; &gt; &gt; @@ -957,23 +978,34 @@ private JSONObject > runTestTaskByGroup(TestTaskSpec testTaskSpec) { &gt; } &gt; > &gt; private JSONObject runTestTaskByDevice(TestTaskSpec testTaskSpec) { > &gt; + if (testTaskSpec.unblockDevice) { &gt; &gt; If the > user wants to block the device and then run 3 tasks, an error &gt; > will occur. Secret detection and unlocking the device should be separated. > &gt; &gt; — &gt; Reply to this email directly, view it on > GitHub &gt; &lt; > #672 (review)&gt;, > &gt; or unsubscribe &gt; &lt; > https://github.com/notifications/unsubscribe-auth/ADU3GOU7A7DZ5ZOPM47MRZD2RLGPHAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMZWGE4TMOJTGI&gt; > &gt; . &gt; You are receiving this because you are subscribed to > this thread.Message &gt; ID: ***@***.***&gt; &gt; > > — > Reply to this email directly, view it on GitHub > < #672 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ACLJZCAZYTYHKY36STBLCKT2RMRSJAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGQ4TQMBRHE> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > — Reply to this email directly, view it on GitHub <#672 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJIQGE2B27ID4TNSWJRWMT2RMSNJAVCNFSM6AAAAABXNXDAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGUZDQMRUGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

bpkroth · 2025-02-24T16:48:52Z

Somehow all/many MS employees were subscribed to "All Activity" for this repo at some point. You can unselect for yourself in the image above, but yes, it'd be nice if folks didn't do this in the first place 🙏 😄

…de the unblockDeviceSecretKey along with the device serial number to run a task on the blocked device with the specific device serial number.

…task.

…e blocked device itself if that task blocks that device earlier.

center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java

olivershen-wow

LGTM for the plugin part.

Ujjwal Srivastava added 3 commits February 18, 2025 16:58

Added blockDevice and unblockDevice in the TestConfig property. Added…

1b09602

… methods in DeviceAgentManagementService to handle blocking and unblocking a device and releasing any frozen blocked devices

Added check that block and unblock device should not be true in the s…

61dab02

…ame test task. Added block device by specific device Identifier

added type specific param check when unblock device is true and devic…

0f723cc

…eIdentifier is a group. Also changed the name of output variable unblockDeviceSecretKey to UnblockDeviceSecretKey

ASPS002 self-assigned this Feb 19, 2025

ASPS002 marked this pull request as ready for review February 21, 2025 05:06

ASPS002 requested review from DexterDreeeam, olivershen-wow, taoran6 and zhou9584 as code owners February 21, 2025 05:06

zhou9584 reviewed Feb 24, 2025

View reviewed changes

center/src/main/java/com/microsoft/hydralab/center/service/TestTaskService.java Show resolved Hide resolved

center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java Outdated Show resolved Hide resolved

ASPS002 removed their assignment Feb 24, 2025

Ujjwal Srivastava and others added 5 commits February 25, 2025 12:21

added support to run test on blocked devices. The task needs to provi…

90192d4

…de the unblockDeviceSecretKey along with the device serial number to run a task on the blocked device with the specific device serial number.

unblock a device after its status has been updated to testing by the …

e949b99

…task.

fixed failures in task :center:checkstyleMain

82dd16a

fixed failing tests runTestOnDeviceWithApp

08174fa

Added data members for Task class and added logic to retry task on th…

0e35af8

…e blocked device itself if that task blocks that device earlier.

zhou9584 reviewed Feb 27, 2025

View reviewed changes

center/src/main/java/com/microsoft/hydralab/center/service/DeviceAgentManagementService.java Show resolved Hide resolved

olivershen-wow previously approved these changes Feb 27, 2025

View reviewed changes

Ujjwal Srivastava added 2 commits February 28, 2025 11:52

added validations for blocking and unblocking a device on center side

bec5e2c

modified exception msg when block and unblock both true

8bdbf87

ASPS002 dismissed olivershen-wow’s stale review via 8bdbf87 February 28, 2025 08:29

zhou9584 approved these changes Mar 3, 2025

View reviewed changes

olivershen-wow approved these changes Mar 3, 2025

View reviewed changes

ASPS002 merged commit cbc34c7 into main Mar 3, 2025
7 checks passed

ASPS002 deleted the user/ujsrivastava/block_unblock_device_test_spec branch March 3, 2025 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User/ujsrivastava/block unblock device test spec#672

User/ujsrivastava/block unblock device test spec#672
ASPS002 merged 10 commits intomainfrom
user/ujsrivastava/block_unblock_device_test_spec

ASPS002 commented Feb 19, 2025 •

edited

Loading

Uh oh!

ASPS002 commented Feb 19, 2025

Uh oh!

Uh oh!

Uh oh!

rakirs2 commented Feb 24, 2025 via email

Uh oh!

girmaw commented Feb 24, 2025 via email

Uh oh!

shaleen commented Feb 24, 2025

Uh oh!

losamig commented Feb 24, 2025 via email

Uh oh!

bpkroth commented Feb 24, 2025

Uh oh!

Uh oh!

olivershen-wow left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

ASPS002 commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked GitHub issue ID: #673

Pull Request Checklist

Does this introduce a breaking change?

How you tested it

Feature UI screenshots or Technical design diagrams

Uh oh!

ASPS002 commented Feb 19, 2025

Uh oh!

Uh oh!

Uh oh!

rakirs2 commented Feb 24, 2025 via email

Uh oh!

girmaw commented Feb 24, 2025 via email

Uh oh!

shaleen commented Feb 24, 2025

Uh oh!

losamig commented Feb 24, 2025 via email

Uh oh!

bpkroth commented Feb 24, 2025

Uh oh!

Uh oh!

olivershen-wow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ASPS002 commented Feb 19, 2025 •

edited

Loading