[CUDA] [fix] enable max_depth in cuda tree learner - fix build#7017
[CUDA] [fix] enable max_depth in cuda tree learner - fix build#7017lorenzolucchese wants to merge 10 commits intomicrosoft:fix-6969from
Conversation
|
@microsoft-github-policy-service agree company="GSA Capital" |
jameslamb
left a comment
There was a problem hiding this comment.
Thanks for this. I'll let @shiyu1994 comment on the C++ changes.
Please see my suggestions on the testing changes. I do agree that #6994 needs at least one test like this, but I'd change the way it's written.
If you don't have the time or interest in addressing that feedback, please let me know and I'll just push the changes directly in a separate PR.
Co-authored-by: James Lamb <jaylamb20@gmail.com>
|
@shiyu1994 do you think you could take a quick look? I think this should be good to merge. Thank you! |
jameslamb
left a comment
There was a problem hiding this comment.
Thanks for the changes, I don't have any further comments.
@shiyu1994 could you please merge this if you agree, and continue with #6994? It'd be great to get #6994 into the next release.
Consistency with cpu meaning of max_depth
Small changes to fix the cuda build for the PR #6994. I also added a test checking the
max_depthparameter is indeed enforced to the python package tests.I tested this locally as follows:
1. Clone, modify and install
lightgbmlocallyMy system:
2. Test that
max_depthis indeed enforced (cf. Issue #6969)Reproducible example