Update export of role group members#6831
Open
FabienTschanz wants to merge 1 commit intomicrosoft:Devfrom
Open
Conversation
ff5ee23 to
33f054a
Compare
33f054a to
4256239
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR updates the export format of the
SCRoleGroupMemberresource, where we now use theAliasproperty if it is an email address. Fallback toNamefor every other type, like Service principals. This is to ensure uniqueness in a tenant, where multiple users with the same name can exist.Due to the nature of this change (updating the name to its alias), this will result in drifts although the user itself didn't change, but our logic is not able to detect that without resolving the user. Therefore, I'll mark this as a breaking change.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).