This repository was archived by the owner on Sep 12, 2024. It is now read-only.
Fixed case where comparing stdout bytes to a string issue 797#798
Open
jineshcodes wants to merge 1 commit intomasterfrom
Open
Fixed case where comparing stdout bytes to a string issue 797#798jineshcodes wants to merge 1 commit intomasterfrom
jineshcodes wants to merge 1 commit intomasterfrom
Conversation
Contributor
jineshcodes
commented
May 13, 2021
| Incident ID or link | #797 |
|---|---|
| Issue summary | Configurations with nxService resource where the service falls under servicemd fails for Python3 during get_marshall() |
| Impact | All distros running on python 3 will not be able to use configurations which try to set service that falls under servicemd for nxService resource. The service will not crash but fail gracefully. |
| Root cause | The reason the get_mashall() is failing is because of a comparison between string and stdout. For python 3 stdout can be in bytes. Issue in line: https://github.com/microsoft/PowerShell-DSC-for-Linux/blob/v1.2.0-0/Providers/Scripts/3.x/Scripts/nxService.py#L858 |
| Reason for not getting caught before release | This scenario was not covered as a part of test suite or manual tests. Manual tests were only done for major scenarios and not for corner cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.