Open
Conversation
Author
|
This PR addresses the CUDA Out of Memory issue discussed in #152 Following the maintainers' feedback that the project needs code-based solutions rather than documentation, I've implemented optional quantization support to directly solve the VRAM limitation problem. |
YaoyaoChang
reviewed
Dec 10, 2025
| return | ||
|
|
||
| full_script = scripts.replace("’", "'").replace('“', '"').replace('”', '"') | ||
| full_script = scripts.replace("'", "'").replace('"', '"').replace('"', '"') |
Collaborator
There was a problem hiding this comment.
Pay attention to your code agent. DO NOT introduce bugs like this.
Author
There was a problem hiding this comment.
Will pay attention to this, and I have corrected it.
What are your thoughts on the quantization approach? Is it going in right direction or Should I change something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of Quantization Support
Following the maintainers' guidance to contribute code rather than documentation, this PR implements the quantization feature discussed previously.
Problem: VibeVoice requires 20GB VRAM, blocking 90% of users
Solution: Optional quantization via
--quantizationparameter (8bit/4bit)Result: Reduces VRAM to 12GB (8-bit) or 7GB (4-bit) with minimal quality loss
Key Features:
Ready for testing and feedback. Happy to make adjustments as needed!