Consume projections via nupkg vs. checked-in binaries#2733
Consume projections via nupkg vs. checked-in binaries#2733msft-Jeyaram wants to merge 17 commits intomicrosoft:developfrom
Conversation
|
There is two instance of WINOBJC_SDK\ usage, that is being cleaned up now :) |
|
@rajsesh-msft the projection code is generated after applying the fixes to winmd2objc (my other CRs) #ByDesign |
rajsesh
left a comment
There was a problem hiding this comment.
Per offline discussion, let us not check-in the generated code. Since this doesn't need to be built every day, we could just wrap the generation step in a script or a build task. This also doesn't have to be nightly built either.
msvc/sdk-build.props
Outdated
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Condition="'$(BuildingFrameworksCore)' != 'true'" Include="WinObjC.Frameworks.UWP" Version="*" /> |
There was a problem hiding this comment.
This is an interesting approach!
Do you think it should go down with the other PackageReferences?
There was a problem hiding this comment.
nope, we want to avoid Frameworks.Core from consuming this package.
There was a problem hiding this comment.
That doesn't mean it can't go in the same block of package references... that just means we have to keep the Condition
There was a problem hiding this comment.
ah, I assumed you meant to just include it without the condition.
Consider it moved.
| <ItemGroup> | ||
| <ClInclude Include="..\..\..\..\tests\unittests\Starboard\LifetimeCounting.h" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
old method was not using the local package, if we can't find a package locally, we look it up in mscodehub
ac37502 to
4e5e83b
Compare
|
This saw random failures with NotificationQueue and filemanager tests. |
|
ping! @rajsesh-msft @DHowett-MSFT |
DHowett-MSFT
left a comment
There was a problem hiding this comment.
Moderately apprehensive about using BuildingFrameworksCore to turn off the package reference instead of inserting the package reference in every project that consumes UWP.
Also, don't our internal frameworks avoid Projections now? They should be generally free of it, and we might not want to even ALLOW them to link against it so we don't accidentally reintroduce dependencies.
This will establish the WinObjC.Frameworks.UWP/MSAds packages and will be consumed by projects via the nupkg
Fixes #2688, #2687
This change is