fix(azure): handle None values in streaming tool_calls#7178
Open
VedantMadane wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(azure): handle None values in streaming tool_calls#7178VedantMadane wants to merge 1 commit intomicrosoft:mainfrom
VedantMadane wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When streaming tool calls via AzureAIChatCompletionClient, the delta can have None values for id, function.name, or function.arguments. This causes a TypeError when concatenating strings. This fix adds None guards before concatenation, matching the pattern already used in the OpenAI client implementation. Fixes microsoft#7157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes TypeError when streaming tool calls via AzureAIChatCompletionClient when delta chunks have None values.
Problem
When using
AzureAIChatCompletionClientwith streaming enabled (model_client_stream=True) and tool calls, the code crashes with:This occurs because
tool_call_chunk.id,tool_call_chunk.function.name, ortool_call_chunk.function.argumentscan beNonein streamed deltas from Azure AI (GitHub Models / Azure AI Foundry).Root Cause
The Azure client unconditionally concatenates these fields:
Solution
Add None guards before concatenation, matching the pattern already used in the OpenAI client:
Testing
This fix follows the same pattern as the OpenAI client (
_openai_client.pylines 986-993), which already handles None values correctly.Environment
Fixes #7157