fix: multi-source nodes can be skipped under max_turns#7187
Open
majiayu000 wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: multi-source nodes can be skipped under max_turns#7187majiayu000 wants to merge 2 commits intomicrosoft:mainfrom
majiayu000 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When a node has multiple incoming edges, the current "all" activation only enqueues the target after the final parent runs. In a graph like P -> U, P -> E, U -> E with max_turns=2, E never runs because it would be scheduled in a third turn. This change queues the target once any parent triggers, so E can run in the second turn alongside U and avoids being skipped under tight turn budgets.
Repro
Output (before):
Output (after):
Related issue number
Checks