updated typed-rest-client to 2.2.0 to fix qs vulnerability in azure-arm-rest package #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
starkmsu
reviewed
Jan 23, 2026
| function readXmlFile(path: string): ltx.Element { | ||
| const buffer = fs.readFileSync(path); | ||
| const encoding = detectFileEncoding(path, buffer)[0].toString(); | ||
| const encoding = detectFileEncoding(path, buffer)[0].toString() as BufferEncoding; |
Contributor
There was a problem hiding this comment.
Here and below we need to handle a case when detectFileEncoding(path, buffer)[0].toString() can't be converted to BufferEncoding.
According to the current implementation of detectFileEncoding it can return null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updated typed-rest-client to 2.2.0 to fix qs vulnerability in azure-arm-rest package
Package Name
azure-arm-rest package
Risk Assessment (Low / Medium / High)
Low
Unit Tests Added or Updated
No
Additional Testing Performed
L0 test cases are passed
Documentation Changes Required (Yes / No)
No
Dependencies
_No