More robust parsing and arg validation for build.sh#1342
Merged
ThomsonTan merged 1 commit intomainfrom Apr 7, 2025
Merged
Conversation
Contributor
|
@DSMitten - while looks unlikely, can you ensure that this doesn't break the existing scripts which internally invoke build.sh . As here - cpp_client_telemetry/build-docker.sh Line 15 in c380bc8 |
lalitb
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue prompting this PR is #1341, where a positional argument following a switch will cause the switch to be swallowed and not evaluated.
This PR changes how commands are parsed so that:
Additionally, there was a conflict between the usage statement and logic, in that the usage statement referred to a positional argument
CUSTOM_CMAKE_CXX_FLAGS=x, but the actual parser looked for an argumentCUSTOM_BUILD_FLAGS=xand set a variableCUSTOM_CMAKE_CXX_FLAG. The usage statement is updated to reflect the argument.Testing performed includes:
./build.sh noroot -DBUILD_UNIT_TESTS=NO -DBUILD_FUNC_TESTS=NObuilds successfully