This repository was archived by the owner on Nov 16, 2023. It is now read-only.
feat: Disallow "strict": false#277
Merged
sandersn merged 1 commit intomicrosoft:masterfrom Mar 2, 2020
Merged
Conversation
ExE-Boss
force-pushed
the
feat/disallow-strict-false
branch
from
0984e01 to
40c70ac
Compare
9 tasks
sandersn
approved these changes
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disallows setting
"strict": falsein DefinitelyTyped packages, as there’s no package that hasstrictset tofalse, only 3 that have it set totrue.I’m opening this as a new PR, because #275 depends on all DefinitelyTyped packages having
"noImplicitAny": true, which will require fixing the remaining 49 packages that won’t yet be fixed by DefinitelyTyped/DefinitelyTyped#42682.I’ve also disallowed overriding
"strict": truewith"noImplicitAny","noImplicitThis","strictNullChecks"or"strictFunctionTypes", as no DefinitelyTyped package does this either.