This repository was archived by the owner on Nov 16, 2023. It is now read-only.
typesVersions parent isn't external dependency#314
Open
jablko wants to merge 1 commit intomicrosoft:masterfrom
Open
typesVersions parent isn't external dependency#314jablko wants to merge 1 commit intomicrosoft:masterfrom
jablko wants to merge 1 commit intomicrosoft:masterfrom
Conversation
jablko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If e.g. in
types/boring/ts1.0you reference../boring-tests.ts, then without this change when lintingtypes/boring/ts1.0dtslint ignores$ExpectErrorand$ExpectTypeassertions intypes/boring/boring-tests.tsand instead the expected errors cause it to fail.Currently
isExternalDependency()checks whether files (types/boring/boring-tests.ts) are inside thedirPath(types/boring/ts1.0). This change updates it to check whether they're insidedirname(dirPath)(types/boring) ifdirPathis atypesVersionsdirectory (e.g.ts1.0).