This repository was archived by the owner on Nov 16, 2023. It is now read-only.
replace tslint with eslint for repo itself#318
Merged
sandersn merged 2 commits intomicrosoft:masterfrom Mar 25, 2021
Merged
Conversation
sandersn
approved these changes
Mar 25, 2021
Member
sandersn
left a comment
There was a problem hiding this comment.
Seems like a good start. I'll merge shortly.
Contributor
Author
|
Great, thanks a lot for taking time to pick it up and get it merged 👍 |
This was referenced Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened #305 ages back to move dtslint off tslint completely, as it has been deprecated for a very long time now.
however that turned out to be a huge task so im just trying to split it up a bit.
this PR moves the repo itself to being linted by eslint rather than tslint, but leaves the source roughly the same (using tslint).
some notes:
unknownmore etc or strongly typing thoseanyuses