-
Notifications
You must be signed in to change notification settings - Fork 90
fix: msdsn improvements for TrustServerCertificate and IPv6 #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: msdsn improvements for TrustServerCertificate and IPv6 #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR provides two independent improvements to the msdsn package: adding a TrustServerCertificate field to the Config struct and fixing IPv6 address formatting in generated URLs.
Changes:
- Adds
TrustServerCertificateboolean field toConfigstruct to expose this connection parameter to callers - Fixes
Config.URL()to properly bracket IPv6 addresses when combined with ports (e.g.,[::1]:1433instead of::1:1433) - Updates
parseTLSfunction signature to return the trustServerCert value for storage in Config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 75.36% 78.59% +3.23%
==========================================
Files 34 34
Lines 6597 6598 +1
==========================================
+ Hits 4972 5186 +214
+ Misses 1337 1134 -203
+ Partials 288 278 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ba87d10 to
2fcbb73
Compare
Two independent fixes to the msdsn package:
Changes
1. TrustServerCertificate Field
Adds
TrustServerCertificateboolean field tomsdsn.Configstruct, making this important connection parameter accessible to callers.2. IPv6 URL Generation Fix
Fixes
Config.URL()to properly bracket IPv6 addresses in generated URLs, preventing malformed URLs likesqlserver://user@::1:1433(now correctly generatessqlserver://user@[::1]:1433).Split from #306 for easier review