Faster pose estimation, support for PoseLib and LightGlue#62
Open
Faster pose estimation, support for PoseLib and LightGlue#62
Conversation
sarlinpe
requested review from
mihaidusmanu,
omiksik and
pablospe
as code owners
pablospe
reviewed
Mar 4, 2024
|
|
||
| import pycolmap | ||
| try: | ||
| import poselib |
Contributor
There was a problem hiding this comment.
Maybe adding the installation instructions in README, perhaps also updating the pyproject and Dockerfile. Same for LightGlue.
Collaborator
There was a problem hiding this comment.
I think LightGlue comes with hloc 1.4 already (?)
pablospe
approved these changes
Jun 5, 2024
Collaborator
Author
|
Poke @mihaidusmanu |
| # avoid duplicate observations | ||
| if p3d_id != -1 and p3d_id in p2d_to_p3d[i]: | ||
| for match_idx, ((i, j), p3d_id) in enumerate(zip(matches, p3d_ids)): | ||
| if p3d_id != -1 and (i, p3d_id) in p2d_to_p3d: |
Collaborator
There was a problem hiding this comment.
nit, I guess this is guaranteed to be != -1? So would maybe assert it?
Collaborator
There was a problem hiding this comment.
(and maybe the check should be against invalid_point3d_id?)
mihaidusmanu
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recover_matches_2d3dcc @vlarsson