Fix crash on disabled TitleBarPaneToggleButton style

[Zakariathr22]

Fixes

• Fixes Cannot find a Resource with the Name/Key TitleBarPaneToggleButtonForegroundDisabled #10739

PR Type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Description

Fixes a crash when disabling the TitleBarPaneToggleButtonStyle.
The crash was caused by a storyboard targeting an invalid property (Background on AnimatedIcon) and by the absence of a TitleBarPaneToggleButtonForegroundDisabled resource.

Current Behavior

• Disabling a button with the style causes the app to crash.
• Crash occurs because AnimatedIcon does not support Background, and the style references a missing resource.

New Behavior

• Storyboard now targets RootGrid.Background instead of AnimatedIcon.Background.
• A new resource TitleBarPaneToggleButtonForegroundDisabled has been added.
• Button disables gracefully without crashing, with proper visual feedback.

Motivation and Context

This change prevents application crashes when the button is disabled.

How Has This Been Tested?

• I have performed a self-review of my own code
• I have added tests to cover my changes

Screenshots (if appropriate):

[beth-panx]

Hey @Zakariathr22 - I am mirroring your changes in the internal repo and adding tests for it too. This will be added to the next release. Does that sound good?

[Zakariathr22]

Hey @Zakariathr22 - I am mirroring your changes in the internal repo and adding tests for it too. This will be added to the next release. Does that sound good?

Sounds good 👍

[Jay-o-Way]

@beth-panx any ETA?

[beth-panx]

@beth-panx any ETA?

The changes are checked in to the winui3/main branch in the correct file now. This will make it to WASDK2.0 release as technically it would be an API change.

[dotMorten]

Hopefully in the future we'll see the community contributions be merged instead and give credit where credit is due.

[beth-panx]

Hopefully in the future we'll see the community contributions be merged instead and give credit where credit is due.

Definitely! After the OSS phase 3 completion, we should be able to do that. Right now, I am just tagging them :/

[Jay-o-Way]

technically it would be an API change

That doesn't make sense to me. This simply looks like a typo fix. Hope this is merged in asap, because many projects are waiting for this!

[Jay-o-Way]

@beth-panx any update?

[beth-panx]

@beth-panx any update?

This change is already merged in main branch. The release of the SDK goes through many review processes. Packaged version will likely be out end of March.