CueStyler: Fix outline rendering of TimedTextCue elements#9224
Open
softworkz wants to merge 1 commit intomicrosoft:winui3/release/1.5-stablefrom
Open
CueStyler: Fix outline rendering of TimedTextCue elements#9224softworkz wants to merge 1 commit intomicrosoft:winui3/release/1.5-stablefrom
softworkz wants to merge 1 commit intomicrosoft:winui3/release/1.5-stablefrom
Conversation
microsoft-github-policy-service
bot
added
the
needs-triage
Contributor
Author
Comparison 1: Large Outline ValuesCurrent Implementation
This PR but with 8 Iterations
This PR but with 16 Iterations
This PR (using 32 Iterations)
|
Contributor
Author
Comparison 2: Smaller Outlines, Bold and Rounded FontCurrent Implementation
This PR but with 8 Iterations
This PR but with 16 Iterations
This PR (using 32 Iterations)
|
Contributor
Author
Comparison 2b: Same as 2 but scaled to 200%Current Implementation
This PR but with 8 Iterations
This PR but with 16 Iterations
This PR (using 32 Iterations)
|
Contributor
Author
|
Further improvement would be to:
|
Contributor
Author
|
@bpulliam - What does the removal of the "needs-triage" label mean? What is the outcome of your triage? |
Contributor
|
@bpulliam Could this PR be reviewed please? |
nikolayvpavlov
suggested changes
Apr 6, 2025
riverar
approved these changes
Dec 15, 2025
Contributor
Author
|
Thanks for the approval. Please let me know when I need to do anything regarding CLA: 
IIRC, I have agreed already, but not sure.. |
Contributor
|
@softworkz If that bot says you haven't done it, it's probably not done. (Or perhaps the CLA got tweaked and needs re-signing?) Oh actually, seems like it's just broken and probably needs a new (empty or otherwise) commit in this PR. |
softworkz
force-pushed
the
winui3/release/1.5-stable_fixoutlines
branch
from
7b02acd to
b6e16a4
Compare
Contributor
Author
Yup, that's what I mean.t
Forrce-pushed a message change of the commit in both PRs and now it's gone. |
softworkz
force-pushed
the
winui3/release/1.5-stable_fixoutlines
branch
from
b6e16a4 to
efd3c07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current method of simulating text outlines is wrong in the way how the visuals are offset in diagonal directions.
Also, the number of visuals for simulating the effect is insufficient for creating an acceptable appearance.
I will follow up with some comparisons.