fix: correctly close all file pointers when creating apple pty#825
Closed
Patrick-Beuks wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix: correctly close all file pointers when creating apple pty#825Patrick-Beuks wants to merge 1 commit intomicrosoft:mainfrom
Patrick-Beuks wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
|
Thank you for the PR, closing in favor of #882 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up all file descriptors correctly as the before
low_fds[0]could never be closed due to thecount > 0condition.This makes it so that if the slave exits all tty descriptors can be cleaned.
Before this change the tty descriptors would keep increasing until the
sysctl kern.tty.ptmx_maxlimit and closing terminals would not make possible to create new terminals.This also fixes a logic error in that
res = grantpt(*master) || unlockpt(*master);could never be-1Note:
While this solves the issue with tty descriptors on successful creation, it can still leak descriptors when it fails before errors got to the
donelabel. I tried adding a cleanup step on errors, but could not get it working in the time allotted to fix this problem.