Enable C++20 for more builds #27178
Open
Enable C++20 for more builds #27178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore/providers/vitisai/imp/global_api.cc
edgchen1
commented
Feb 2, 2026
| --cmake_extra_defines onnxruntime_BUILD_UNIT_TESTS=OFF | ||
| # Job 7: Extended minimal build with NNAPI EP for Android(arm64-v8a) and skip tests. | ||
| # NOTE: Keeping this as direct docker run due to custom volume mounts needed for Android SDK/NDK |
Contributor
Author
There was a problem hiding this comment.
there's an error with CMake not finding clang-scan-deps from the NDK for the particular configuration of:
- Linux build with Docker container
- C++20
- Ninja generator
it works fine when running outside of Docker. this is what the other Android CI builds do, e.g., here:
onnxruntime/.github/workflows/android.yml
Line 194 in a5dc0f9
I just simplified this to make it consistent instead of debugging further for now.
edgchen1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable C++20 for more builds. Previously, it was limited to MacOS builds. Now, it is enabled for all builds except for ones with the CUDA EP enabled.
Motivation and Context
Working towards updating to the C++20 standard to enable use of new language and standard library features.