[WebGPU EP] Remove unused has_bias in MatMul::ComputeInternal
#27211
+3
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `MatMul` operator doesn't support `bias` as its input, we don't need to handle `bias` in `MatMul::ComputeInternal`.
qjia7
reviewed
Jan 30, 2026
| return intel::ApplyMatMulIntel(context, Activation(), inputs, output_tensor); | ||
| } | ||
|
|
||
| return ComputeMatMul(&context, Activation(), inputs, output_tensor, false); |
Contributor
There was a problem hiding this comment.
I believe it should be return ComputeMatMul(&context, Activation(), inputs, output_tensor, true); instead of return ComputeMatMul(&context, Activation(), inputs, output_tensor, false);. The previous one will prevent you go to the splitK path.
Please consider directly return ComputeMatMul(&context, Activation(), inputs, output_tensor, true) in line 118 and move all necessary optimizations in ComputeMatMul to reduce duplicated code.
Contributor
|
Is this bias reserved for fusing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch removes all the logic that handles
biasinMatMul::ComputeInternal().Motivation and Context
As
MatMuloperator doesn't supportbiasas its input, we don't need to handlebiasinMatMul::ComputeInternal().