Skip to content

Fix WebGPU ConvTranspose bias validation in TypeScript and C++ implementations #27213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guschmue merged 12 commits into from
Feb 6, 2026
Merged

Fix WebGPU ConvTranspose bias validation in TypeScript and C++ implementations #27213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1488dc3
Initial plan
Copilot Jan 30, 2026
d3658b0
Enhance ConvTranspose bias validation with better error messages
Copilot Jan 30, 2026
a7b6b3a
Address code review feedback - use nullish coalescing and remove redu…
Copilot Jan 30, 2026
583f08b
Fix group attribute default at parse time instead of validation time
Copilot Jan 30, 2026
0d53e11
Add bias validation to C++ WebGPU ConvTranspose implementation
Copilot Jan 30, 2026
d8dc88a
Apply suggestion from @github-actions[bot]
guschmue Jan 30, 2026
7c969c5
Apply suggestion from @github-actions[bot]
guschmue Jan 30, 2026
cf72464
Apply suggestion from @github-actions[bot]
guschmue Jan 30, 2026
7c55b81
Run prettier to fix formatting in conv-transpose.ts
Copilot Jan 30, 2026
4c850b7
Merge bias validation conditions and simplify error message
Copilot Feb 5, 2026
fcdab4f
Apply suggestion from @github-actions[bot]
guschmue Feb 5, 2026
9c9ef07
Fix formatting with lintrunner
Copilot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/web/lib/wasm/jsep/webgpu/ops/conv-transpose.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export const parseConvTransposeAttributes = (attributes: Record<string, unknown>
typeof attributes.autoPad == 'undefined' ? 0 : (attributes.autoPad as number)
];
const dilations = attributes.dilations as [number, number];
const group = attributes.group as number;
const group = (attributes.group as number) ?? 1; // default to 1 per ONNX spec
const kernelShape = attributes.kernelShape as [number, number];
const pads = attributes.pads as [number, number, number, number];
const strides = attributes.strides as [number, number];
Expand Down
5 changes: 5 additions & 0 deletions onnxruntime/core/providers/webgpu/nn/conv_transpose.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ Status ConvTranspose<is_channels_last>::ComputeInternal(ComputeContext& context)

bool has_bias = context.InputCount() > 2;
const auto* bias = has_bias ? context.Input<Tensor>(2) : nullptr;
// Validate bias shape if provided
if (has_bias && (bias->Shape().NumDimensions() != 1 || bias->Shape()[0] != num_output_channels)) {
return ORT_MAKE_STATUS(ONNXRUNTIME, INVALID_ARGUMENT, "invalid bias");
}

if (input_shape.NumDimensions() == 3 && filter_shape.NumDimensions() == 3) {
// ConvTranspose1D
TensorShapeVector input_shape_vector = input_shape.AsShapeVector();
Expand Down
Loading