[Kernel] Fix bug in Einsum implementation when a lone operand had a reduction operation#27225
Merged
hariharans29 merged 12 commits intomainfrom Feb 6, 2026
Merged
[Kernel] Fix bug in Einsum implementation when a lone operand had a reduction operation#27225hariharans29 merged 12 commits intomainfrom
hariharans29 merged 12 commits intomainfrom
Conversation
hariharans29
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
onnxruntime/core/providers/cpu/math/einsum_utils/einsum_typed_compute_processor.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/cpu/math/einsum_utils/einsum_typed_compute_processor.cc
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Einsum implementation that occurred when a single input operand underwent both a reduction and transpose operation. The issue manifested as a shape mismatch error where the candidate output rank didn't match the number of subscript indices.
Changes:
- Fixed the rank mismatch issue by ensuring all dimensions (including reduced ones with value 1) are tracked when calling FinalizeOutput for single-input cases
- Added an ORT_ENFORCE check to catch this type of internal bug earlier in FinalizeOutput
- Added a test case covering the specific bug scenario ("ijk->ki" equation)
- Improved comment clarity by adding "relative" to describe order preservation in IsTransposeReshapeForEinsum
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| onnxruntime/core/providers/cpu/math/einsum_utils/einsum_typed_compute_processor.cc | Fixed single-input reduction bug by changing from preserved_dims to all_dims, added validation check, improved comment |
| onnxruntime/test/providers/cpu/math/einsum_test.cc | Added test case for the reduce-with-transpose scenario that was previously failing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
onnxruntime/core/providers/cpu/math/einsum_utils/einsum_typed_compute_processor.cc
Outdated
Show resolved
Hide resolved
…compute_processor.cc Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…compute_processor.cc Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…compute_processor.cc Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
onnxruntime/core/providers/cpu/math/einsum_utils/einsum_typed_compute_processor.cc
Outdated
Show resolved
Hide resolved
…compute_processor.cc Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hariharans29
changed the title
edgchen1
previously approved these changes
Feb 5, 2026
onnxruntime/core/providers/cpu/math/einsum_utils/einsum_typed_compute_processor.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/cpu/math/einsum_utils/einsum_typed_compute_processor.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/cpu/math/einsum_utils/einsum_typed_compute_processor.cc
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
onnxruntime/core/providers/cpu/math/einsum_utils/einsum_compute_preprocessor.h
Show resolved
Hide resolved
onnxruntime/core/providers/cpu/math/einsum_utils/einsum_typed_compute_processor.cc
Outdated
Show resolved
Hide resolved
…compute_processor.cc Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…runtime into hari/einsum_fix_1
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edgchen1
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the lone operand had a reduction operation in Einsum, there was a mis-management in the shape which led to a mis-match in terms of the subscript indices in the output as deciphered from the Einsum equation and the rank of the candidate output being produced after the reduction operation which caused issues while finalizing the output of the Einsum op.
This change fixes the bug and adds a test
Motivation and Context
Resolve #18654