Fix SHIFT+F10 keyboard shortcut for context menu in TextInput #15621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the SHIFT+F10 keyboard shortcut not working to show the context menu in TextInput components. Previously, pressing SHIFT+F10 would cause the application's File menu to blink instead of showing the TextInput context menu.
Type of Change
Why
The SHIFT+F10 keyboard shortcut is a standard Windows accessibility feature for opening context menus. Users expect this shortcut to work in TextInput fields to access cut/copy/paste operations via keyboard.
Root Cause: Windows intercepts SHIFT+F10 at the system level. For ContentIsland hosting, the
InputKeyboardSource.ContextMenuKeyevent wasn't being handled, so the event would fall through and activate the application's menu bar instead.What
The following changes were made to fix the issue:
Added
OnContextMenuvirtual method toComponentView- Base class method that derived components can override to handle context menu requests.Added
ContextMenuKeyevent handler inCompositionEventHandler- For ContentIsland hosting, this subscribes toInputKeyboardSource.ContextMenuKeyand routes the event to the focused component'sOnContextMenumethod.Added
WM_CONTEXTMENUhandling inCompositionEventHandler::SendMessage- For HWND hosting (CompositionHwndHost), this routes the WM_CONTEXTMENU message to the focused component.Implemented
OnContextMenuinWindowsTextInputComponentView- CallsShowContextMenu()when the context menu is not hidden via props.Screenshots
N/A
Testing
Manual Testing Performed:
contextMenuHiddenprop still prevents context menu from appearingTest Scenarios:
contextMenuHidden={true}+ SHIFT+F10 → No context menuChangelog
Should this change be included in the release notes: yes
Fixed SHIFT+F10 keyboard shortcut not showing context menu in TextInput components.