Skip to content

feat(spark_environment_settings): migrate Resource/Data-Source to Use GA APIs#817

Open
catalina-gav wants to merge 9 commits intomainfrom
dev/catalinagav/env-settings-use-ga-api
Open

feat(spark_environment_settings): migrate Resource/Data-Source to Use GA APIs#817
catalina-gav wants to merge 9 commits intomainfrom
dev/catalinagav/env-settings-use-ga-api

Conversation

@catalina-gav
Copy link
Contributor

📥 Pull Request

❓ What are you trying to address

Close #809

@catalina-gav catalina-gav self-assigned this Feb 10, 2026
@catalina-gav catalina-gav requested a review from a team as a code owner February 10, 2026 08:20
Copilot AI review requested due to automatic review settings February 10, 2026 08:20
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Changelog Preview

v1.7.1-dev - February 16, 2026

✨ Added

  • #661 Onboard new fabric_digital_twin_builder_flow Data Source
  • #662 Onboard new fabric_digital_twin_builder_flow Resource
  • #708 Onboard fabric_tenant_settings and fabric_tenant_setting datasource
  • #709 Onboard fabric_tenant_setting resource
  • #773 Onboard new fabric_map Data Source
  • #774 Onboard new fabric_map Resource
  • #704 Enhanced fabric_workspace_git resource by adding new allow_override_items attribute

💫 Changed

  • #801 add support for fabric_domain GA APIs, removed preview for fabric_domain
  • #809 migrate fabric_spark_environment_settings resource/data-source to use GA APIs

🪲 Fixed

  • #767 Fix resource fabric_spark_environment_setting update pool not working

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the spark_environment_settings resource and data source from preview endpoints to GA Fabric APIs (issue #809), and updates the Terraform-facing schema/docs accordingly.

Changes:

  • Switches Spark environment settings CRUD calls from *Preview GA-deprecated methods to GA methods (UpdateSparkCompute, GetSparkCompute, PublishEnvironment).
  • Refactors spark_properties from a map to a list of nested { key, value } objects across schema/models/tests.
  • Removes “preview mode” messaging and flags in docs/examples and marks the item as non-preview.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
internal/services/sparkenvsettings/schema.go Updates schema for GA alignment and changes spark_properties to a nested-list structure.
internal/services/sparkenvsettings/models.go Updates model/request/response mapping for GA types and new spark_properties representation.
internal/services/sparkenvsettings/resource_spark_environment_settings.go Swaps preview API calls for GA APIs and updates publish behavior.
internal/services/sparkenvsettings/data_spark_environment_settings.go Updates data source read path to GA GetSparkCompute.
internal/services/sparkenvsettings/resource_spark_environment_settings_test.go Updates acceptance test config/assertions for new spark_properties shape.
internal/services/sparkenvsettings/base.go Marks the item as non-preview.
examples/resources/fabric_spark_environment_settings/resource.tf Updates example configuration for new spark_properties list shape.
docs/resources/spark_environment_settings.md Removes preview notes and updates docs for new spark_properties nested schema.
docs/data-sources/spark_environment_settings.md Removes preview notes and updates docs for new spark_properties nested schema.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Migrate sprark_environment_settings Resource/Data-Source to Use GA APIs

1 participant