feat(spark_environment_settings): migrate Resource/Data-Source to Use GA APIs#817
Open
catalina-gav wants to merge 9 commits intomainfrom
Open
feat(spark_environment_settings): migrate Resource/Data-Source to Use GA APIs#817catalina-gav wants to merge 9 commits intomainfrom
catalina-gav wants to merge 9 commits intomainfrom
Conversation
Changelog Previewv1.7.1-dev - February 16, 2026✨ Added
💫 Changed
🪲 Fixed
|
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the spark_environment_settings resource and data source from preview endpoints to GA Fabric APIs (issue #809), and updates the Terraform-facing schema/docs accordingly.
Changes:
- Switches Spark environment settings CRUD calls from
*PreviewGA-deprecated methods to GA methods (UpdateSparkCompute,GetSparkCompute,PublishEnvironment). - Refactors
spark_propertiesfrom a map to a list of nested{ key, value }objects across schema/models/tests. - Removes “preview mode” messaging and flags in docs/examples and marks the item as non-preview.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/services/sparkenvsettings/schema.go | Updates schema for GA alignment and changes spark_properties to a nested-list structure. |
| internal/services/sparkenvsettings/models.go | Updates model/request/response mapping for GA types and new spark_properties representation. |
| internal/services/sparkenvsettings/resource_spark_environment_settings.go | Swaps preview API calls for GA APIs and updates publish behavior. |
| internal/services/sparkenvsettings/data_spark_environment_settings.go | Updates data source read path to GA GetSparkCompute. |
| internal/services/sparkenvsettings/resource_spark_environment_settings_test.go | Updates acceptance test config/assertions for new spark_properties shape. |
| internal/services/sparkenvsettings/base.go | Marks the item as non-preview. |
| examples/resources/fabric_spark_environment_settings/resource.tf | Updates example configuration for new spark_properties list shape. |
| docs/resources/spark_environment_settings.md | Removes preview notes and updates docs for new spark_properties nested schema. |
| docs/data-sources/spark_environment_settings.md | Removes preview notes and updates docs for new spark_properties nested schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/services/sparkenvsettings/resource_spark_environment_settings.go
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
❓ What are you trying to address
Close #809